Fix: Video duration is displayed incorrectly #37682
Conversation
melvin-bot
bot
requested review from
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| <View style={[styles.videoPlayerControlsRow]}> | ||
| <Text style={[styles.videoPlayerText, styles.videoPlayerTimeComponentWidth]}>{convertMillisecondsToTime(position)}</Text> | ||
| <Text style={[styles.videoPlayerText]}>/</Text> | ||
| <Text style={[styles.videoPlayerText, styles.videoPlayerTimeComponentWidth]}>{durationFormatted}</Text> | ||
| <Text style={[styles.videoPlayerText]}>{convertMillisecondsToTime(position)}</Text> | ||
| <Text style={[styles.videoPlayerText, styles.mh1]}>/</Text> | ||
| <Text style={[styles.videoPlayerText]}>{durationFormatted}</Text> |
There was a problem hiding this comment.
There is a problem with this change. Now the / part moves dynamically when time changes. Let's find a way to keep it fixed. It happens due to some numbers taking more width than others. E.g. 0 takes more space than 1.
There was a problem hiding this comment.
Oh, Ok. Now I understand why a fixed width was added there.
Thanks, I somehow missed this issue.
There was a problem hiding this comment.
One way is to use font MONOSPACE for the time which will take the same space for each digit.
fontFamily: FontUtils.fontFamily.platform.MONOSPACE
Screen.Recording.2024-03-05.at.15.41.31.mov
There was a problem hiding this comment.
Yes, monospace is the way to go here but that will change the font. @shawnborton Could you please help us decide it.
Problem: We want to use dynamic width for the timer UI component on the video player to reduce space. But as some font glyph has different widths, it dynamically changes position on the UI.
There was a problem hiding this comment.
I don't think we want to introduce any new styles here, let's just fix the bug of not displaying the correct values.
cc @Expensify/design
There was a problem hiding this comment.
Sure. That works. Thank you.
Screenshots🔲 iOS / nativeScreen.Recording.2024-03-06.at.1.29.26.AM.mov🔲 iOS / SafariScreen.Recording.2024-03-06.at.1.27.30.AM.mov🔲 MacOS / DesktopScreen.Recording.2024-03-05.at.11.41.26.PM.mov🔲 MacOS / ChromeScreen.Recording.2024-03-05.at.11.39.04.PM.mov🔲 Android / ChromeScreen.Recording.2024-03-06.at.1.34.22.AM.mov🔲 Android / nativeScreen.Recording.2024-03-06.at.1.31.38.AM.mov |
|
I was checking the time calculations and I noticed that Android shows the same video of 17 seconds but our player shows 18. At the same time, iOS shows that as 18 sec. What might be wrong here? |
|
@Pujan92 Thoughts? |
|
Sorry, I missed that comment. I will check and update soon! |
This might be due to the round-off for the number, I have added the Math floor for seconds which I forgot to add earlier. Can you plz check now with the latest code? |
|
I can still see that Android has time differences. All apps on Android are showing 17 secs but our app is showing 18. Check the Android attached video from my screenshots. @Pujan92 |
Yes, I am able to reproduce it on the web also for some videos. Fixed the calculation part. Plz test now. |
|
Now, the issue is showing on iOS. Where video is showing 18 seconds in the media but our player is showing 17 secs. can you try to see the differences between the platforms and try to find out what might be causing it? I think due to this, it might be good to use date object based solution if that solves this issue. |
The issue remains with the date based solution too, I just reverted to earlier date code and in iOS it shows 1 second more. Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-07.at.23.35.17.mp4 |
|
Based on the https://expensify.slack.com/archives/C01GTK53T8Q/p1709888973311129, I think we are good with calculations and ignore the IOS native timing issue. |
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
Details
#37216
Fixed Issues
$ #37216
PROPOSAL: #37216 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2024-03-01.at.18.59.42.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-03-04.at.20.54.34.mp4
Android